User "Aaron Schulz" changed the status of MediaWiki.r102625. Old Status: new New Status: fixme
User "Aaron Schulz" also posted a comment on MediaWiki.r102625. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102625#c25856 Commit summary: * Added getInfinity to DatabaseOracle * Block - replaced 'infinity' strings with DB->getInfinity calls * UploadStash - added sequence value generation for ID Comment: <pre> + $this->addWhereIf( "ipb_expiry = '".$db->getInfinity()."'", isset( $show['!temp'] ) ); + $this->addWhereIf( "ipb_expiry != '".$db->getInfinity()."'", isset( $show['temp'] ) ); </pre> This should use $db->addQuotes() instead of manual double-quotes. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
