User "Catrope" changed the status of MediaWiki.r99119. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99119 Commit summary: [RL2] Optimize module organization * Moving tab-addition into separate module. This tab should only be added on Special:Gadgets (or wherever the tabs module is loaded), not per se wherever ext.gadgets.gadgetmanager is loaded. Until now it was fine in the ext.gadgets.gadgetmanager module since the Create-tab is only useful to people that are gadget managers, for which this module is obviously loaded. However soon I'll add more JS-tabs, some of which are even useful to anonymous users, so this clearly needs to be in a separate module. And the tab isn't part of the 'manager'. * A nice gain: The tab is now created before the page becomes visible, because I gave this tabs-module position top (the manager is and should not be position top) * The ext.gadgets.specialgadgets.tabs module needs mw.gadgets to exist, moving the creation of that object and the 'conf' key out of ext.gadgets.api into a new module (ext.gadgets.init). * Rename 'prejs' to 'specialgadgets.prejk' _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
