User "Krinkle" posted a comment on MediaWiki.r100509. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100509#c25951 Commit summary:
(bug 31414) Skin specific gadgets Comment: <pre> + $gadget->requiredSkins = array_intersect( array_keys( Skin::getSkinNames() ), $params ); </pre> Right now if a gadget is indicated to require a certain skin, and that skin is then removed from the install, it will be available as an option in all skins (because this would return an empty array, and empty array means no requirements according to <code> isAllowed()</code>). Whereas is should probably be hidden for all skins if it requires a skin that doesn't exist. Do we need the array_intersect ? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
