User "Catrope" changed the status of MediaWiki.r102910.

Old Status: new
New Status: fixme

User "Catrope" also posted a comment on MediaWiki.r102910.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102910#c25961
Commit summary:

Bug 32379 - DatabaseError.php is hardcoding http

Also tidy up a couple of returns (per others in method, and/or parents)

Comment:

<pre>
-               $message = "A database error has occurred.  Did you forget to 
run maintenance/update.php after upgrading?  See: 
http://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script\n"; .
+               $message = "A database error has occurred.  Did you forget to 
run maintenance/update.php after upgrading?  See: 
//www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script\n" .
</pre>
This should one should be reverted. URLs that are used inline like that can't 
be protocol-relative. The google.com URL is OK because it's in an HTML 
attribute.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to