User "Mdale" posted a comment on MediaWiki.r98710. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98710#c26010 Commit summary:
Follow-up r84395: Give MediaHandlers the option to remove items from the thumbnail purge list. Is needed for TMH because thumbnail rendering may be very expensive for media files. Haven't thought yet of a way to integrate this with the UI, but the current framework should be flexible enough to implement that later. Added array $options to File::purgeCache(), LocalFile::purgeCache(), LocalFile::purgeThumbnails(), ForeignAPIFile::purgeCache() and ForeignAPIFile::purgeThumbnails() which is currently empty, but can be used later to indicate a full or partial purge. Added MediaHandler::filterThumbnailPurgeList(), which can remove items from the purge list and also gets passed this $options array Comment: I see this was reverted? Why would the above code result in thumbnails not being purged on deletion? What is the current solution for avoiding the removal of expensive to generate thumbnails ( ie video transcodes ) on simple action=purge page requests ? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
