User "Aaron Schulz" changed the status of MediaWiki.r102997. Old Status: new New Status: ok
User "Aaron Schulz" also posted a comment on MediaWiki.r102997. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102997#c26014 Commit summary: Some cleanup to Article::view() and related: * Moved the page check if oldid was given from Article::fetchContent() to Article::getOldidIDFromRequest() so that it's done directly when executing Article::view(); this should not happen though for normal view requests since oldid and related are checked in MediaWiki::parseTitle() * Removed $oldid parameter from Article::fetchContent() and always use the oldid parameter passed either in the constructor or the request; also changed call from Article::loadContent() to Article::fromContent() since the former is now only a redirect to the latter * Moved the 'read' permission check to the beginning of Article::view() since the Title is now correct directly after calling Article::getOldID() * Merged the two calls to the parser cache and make WikiPage::isParserCacheUsed() also return true when the latest revision id is given. Article::setOldSubtitle() is still called when the oldid is passed to display the "You are view the current revision of this article". * Also moved the non-existing page check a bit up to avoid running a good part of useless code when the page doesn't exist * Merged two calls to Title::quickUserCan( 'edit' ) to set edit sections to false Comment: Took a while to inspect this. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
