User "^demon" posted a comment on MediaWiki.r103199.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103199#c26057
Commit summary:

Add wfAssembleUrl and unit tests. This is the next step towards fixing
bug 32168.  This function is the inverse of wfParseUrl and is useful when you
need to modify part of a URL and have to put it back together.

Further, with the addition of this function, there is sufficient code in core
to create a proper URI class.

Comment:

Unless you're specifically wanting to allow null values, isset() is way faster 
than array_key_exists() here.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to