User "Raindrift" changed the status of MediaWiki.r103057. Old Status: new New Status: ok
User "Raindrift" also posted a comment on MediaWiki.r103057. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103057#c26085 Commit summary: Moodbar phase 1 bug fixes, fixes bug32108 and addresses others in FeedbackDashboard requirements Comment: //mb.ui.overlay.find( '.mw-moodBar-formSubmit').removeAttr('disabled'); If you're going to remove code, remove it. Don't commit commented-out code. That's what VC is for. :) Tagging this rev 'todo' for this. if(mb.feedbackItem.comment){ Remember to use the "spacey" style. Sorry to be a pedant about it. Lastly, when working with the keyup event, you may want to introduce a delay into your validation if it's complex. Probably not necessary here at the moment, but for an example of what I'm talking about, check out http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/UploadWizard/resources/mw.DestinationChecker.js (validation methods have a way of growing...) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
