On Wed, Nov 16, 2011 at 12:36 PM, Jeroen De Dauw <[email protected]> wrote: > > Hey, > > > Introducing a pattern like this in a code base this large is therefore > problematic. > > I'm tempted to agree with this. Doing > > $this->getOutput() > ->setPageTitle( wfMsg( 'abusefilter-examine' ) ) > ->addWikiMsg( 'abusefilter-examine-intro' ); > > is less clear then doing > > $out = $this->getOutput(); > $out->setPageTitle( wfMsg( 'abusefilter-examine' ) ); > $out->addWikiMsg( 'abusefilter-examine-intro' ); > > Since it's not obvious if addWikiMsg is getting called on the output object > or on something setPageTitle returns in case of the former. It'll also > break if someone adds a return value. > > IMO this is asking for bugs. >
I fully agree. Bryan _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
