User "Duplicatebug" posted a comment on MediaWiki.r103332. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103332#c26145 Commit summary:
* Use WikiPage instead of Article * Create the WikiPage object directly in execute() and pass it to both delete() and deleteFile() * Reordered parameters of delete() and deleteFile() to be consistent and take both on the WikiPage and User objects (instead of relying on $wgUser); no callers outside of this class * Fixed deleteFile() to match the behaviour of FileDeleteForm with oldimage parameter * Pass the User object to getPermissionsError() * Factorised duplicated code * Added missing error code to ApiBase (and also a new one) * Added missing possible error codes (with a new one too) Comment: <code>'The oldid parameter has invalid format'</code> should be <code>oldimage parameter</code> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
