User "NeilK" posted a comment on MediaWiki.r103368.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103368#c26156
Commit summary:

follow up to r103251, remove array when calling Message::rawParams() and use 
array style to construct query condition

Comment:

In getFeedbackHiddenDetail, it seems that you could possibly return false or 
the empty array. 

It doesn't seem that you are checking those values in the caller.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to