User "Bawolff" posted a comment on MediaWiki.r103471.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103471#c26164
Commit summary:
Apply cryptocoryne's patch from Bug 32454 - ArticlePurge hook is broken after
r86041
Comment:
One thing I'm not sure about - is it appropriate to return false for fail from
onSubmit? The docs for that method say:
<pre>
@return Bool|Array true for success, false for didn't-try, array of errors on
failure
</pre>
I'm not sure if hook arborted should be error instead of "didn't try".
As a note, in my testing, things are still slightly different because something
like (stolen from bug report):
<pre>
$wgHooks['ArticlePurge'][] = 'testArticlePurge';
function testArticlePurge( &$article ) {
global $wgOut;
$wgOut->addWikiMsg( 'error' );
return false;
}
</pre>
Would present an error page with no page title (in the <h1>) in 1.17, but now
would use the page's title in the <h1>. However, I don't think that's something
to really care about.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
