User "Tim Starling" changed the status of MediaWiki.r102507. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102507 Commit summary: fix thumb rotation in non bilinear mode physical height and width are already switched upstream if there is an exif rotation indicator. So we did a double rotation and used bad shrinking parameters. Found this issue with our test suite \o/ TEST PLAN: $ ./phpunit.php --testdox includes/media/ExifRotationTest.php PHPUnit 3.6.2 by Sebastian Bergmann. ExifRotation [x] Metadata [x] Rotation rendering [x] Bitmap extract pre rotation dimensions $ $ make noparser <did not get any errors related to vips or images> $ I have also tested rendering using [[Special:VipsTest]] against the tests/phpunit/data/media/Portrait-rotated.jpg I have uploaded locally. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
