User "Tim Starling" changed the status of MediaWiki.r102867.

Old Status: new
New Status: resolved

User "Tim Starling" also posted a comment on MediaWiki.r102867.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102867#c26182
Commit summary:

Add more validation of input, fix sharpening validation

Comment:

<pre>
-                       if ( $request->getBool( 'sharpen' ) && 
$request->getInt( 'sharpen' ) < 5 ) {
+                       if ( $request->getInt( 'sharpen' ) && $request->getInt( 
'sharpen' ) < 5 ) {
</pre>

This is broken when sharpen is less than 1, e.g. 0.8 is converted to 0 and then 
to false. Fixed in r103572.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to