User "Bryan" posted a comment on MediaWiki.r103309.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103309#c26197
Commit summary:

Better image comparaison using jquery.ucompare

Patch adds jquery.ucompare plugin by userdot.net see a demo at:
http://www.userdot.net/files/jquery/jquery.ucompare/demo/
Demo files have been removed from this local distribution.

I have migrated the existing css/js to a new ext.vipsscaler module which now
only trigger the ucompare system.
Old code left commented so we can easy reenable it if needed :)

KNOWN BUG:
ucompare hides the <img> elements hence the parent div height is set to 0.
It then create two divs using those images as background image but somehow
the parent div height does not get updated and stick to 0. Thus nothing is
shown.  A follow up commit add a patch to jquery.ucompare to fix this.

Comment:

Looks good, but it would be nice to switch the entire image quickly. Perhaps 
that a click on the image should trigger switching the entire thumbnail?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to