User "Nikerabbit" changed the status of MediaWiki.r98670. Old Status: new New Status: ok
User "Nikerabbit" also posted a comment on MediaWiki.r98670. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98670#c26285 Commit summary: * IncubatorTest::onGetUserPermissionsErrors(): do not disallow deleting pages belonging to existing wikis :) * Call linker function statically (the extension is not compatible with 1.17 and lower anyway) * Fix a link for protocol-relative URLs, and make the external links display nicely (without the '//') Comment: <pre> -return $action == 'delete' ? true : false; +return $action === 'delete'; </pre> Latter is sufficient. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
