User "NeilK" changed the status of MediaWiki.r103724. Old Status: new New Status: ok
User "NeilK" also posted a comment on MediaWiki.r103724. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103724#c26320 Commit summary: sync with kaltura trunk: * adds TimeDisplayWidth and ControlsHeight configuration Event name sync: * use the "newEmbedPlayerEvent" event instead of EmbedPlayerNewPlayer * use "checkPlayerSourcesEvent" instead of "CheckPlayerSources" mw.EmbedPlayer.js: * adds methods: useNativePlayerControls, * adds bindHelper methods for close context errors in iOS for plugins * spaces fixes for mw.EmbedPlayer to match kaltura version * add loading spinner support * generalized disable seekBar to enable/disable PlayControls * Comment: spelling: playContorls, chnagePlayingMedia, videoAttribues Re: Bind helpers to help iOS retain bind context - was confusing as to why these are needed. I am assuming that the problem is that you can't bind to something produced by another script, so you need a bind helper method to do it for you. enablePlayControls: real braces for MW style, please otherwise looks ok _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
