User "Raymond" changed the status of MediaWiki.r103865.

Old Status: new
New Status: fixme

User "Raymond" also posted a comment on MediaWiki.r103865.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103865#c26326
Commit summary:

* (bug 32548) fix minification bug when numeric literal with exponent was split 
over lines

This broke the OpenLayers support in the Maps extension, as used for example on 
TranslateWiki.net.
The original JavaScriptMinifier's tokenizer (r83885) explicitly didn't bother 
looking for the exponent part because it "didn't matter" to its internal state 
machine; however since r83891 added a max line length that definitely is not 
true.

I've split out handling of hex and decimal numerals, and let the decimal 
numeral handling check for exponents.

PHPUnit test cases were added in r103846.

Comment:

I still do not see the map on https://translatewiki.net/wiki/User:Raymond

Firefox 9 beta/Chrome 15 complain:
* Error: missing exponent
* Source: 
https://translatewiki.net/w/load.php?debug=false&lang=de&modules=ext.maps.common%2Copenlayers&skin=vector&version=20111122T081531Z&*


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to