User "Brion VIBBER" changed the status of MediaWiki.r103751. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r103751. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103751#c26399 Commit summary: In the spirit of r103745, guard against invalid user names in SpecialContributions and SpecialDeletedContributions by checking for invalidity early, then passing User objects around. Loosely based on Søren Løvborg's patch on bug 26854 Comment: $user = Linker::link( $userObj->getPage(), htmlspecialchars( $userObj->getText() ) ); User doesn't have a getText() method. Did you mean getName()? <pre> Fatal error: Call to undefined method User::getText() in /var/www/trunk/includes/specials/SpecialDeletedContributions.php on line 348 Call Stack: 0.0004 659272 1. {main}() /var/www/trunk/index.php:0 0.0868 19330848 2. MediaWiki->run() /var/www/trunk/index.php:58 0.0868 19330848 3. MediaWiki->main() /var/www/trunk/includes/Wiki.php:524 0.0868 19330984 4. MediaWiki->performRequest() /var/www/trunk/includes/Wiki.php:605 0.0937 19964632 5. SpecialPageFactory::executePath() /var/www/trunk/includes/Wiki.php:237 0.1093 21222416 6. DeletedContributionsPage->execute() /var/www/trunk/includes/SpecialPageFactory.php:470 0.1640 31870560 7. DeletedContributionsPage->getSubTitle() /var/www/trunk/includes/specials/SpecialDeletedContributions.php:299 </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
