User "Catrope" changed the status of MediaWiki.r103665. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r103665. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103665#c26440 Commit summary: Initial insertion of ShortURL entries done in batches Comment: <pre> + $this->output( $insertBuffer ); </pre> Why are you passing an array to <code>$this->output()</code> ?!? <pre> + array_push( $insertBuffer, $rowData ); </pre> IMO <code>$insertBuffer[] = $rowData;</code> is clearer. Other things: * the code is much clearer if you put <code>$insertBuffer = array();</code> at the start of the while loop, rather than at the end * your query is missing an ORDER BY page_id. This is not a problem in practice on MySQL, but may well be one on other DBMSes _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
