User "Tim Starling" changed the status of MediaWiki.r94762. Old Status: resolved New Status: fixme
User "Tim Starling" also posted a comment on MediaWiki.r94762. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94762#c26516 Commit summary: Started rewriting WikiHiero. So far, only parser tag works while the maint functions are broken (however, they're disabled anyway) * Turned global functions into a class * Made images accessible via $wgExtensionAssetsPath instead of $wgScriptPath to make baby Domas not cry :) * The code still needs much more structural changes and stylization - will be done with next commits Comment: <pre> + $contentHtml .= WH_TD_S . self::renderGlyph($code[0]).WH_TD_E; </pre> Static calls of nonstatic functions are not allowed. Several instances. The extension should balance the HTML tags in its output. Try <nowiki><hiero><<<<</hiero></nowiki> for example. Not your fault, but I thought you'd like to know if you're maintaining the extension. Also you should fix the indenting in WikiHiero::render(). Marking fixme for static calls only. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
