User "Johnduhart" posted a comment on MediaWiki.r104388.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104388#c26601
Commit summary:
improvement in use of arrays per feedback to r104384 - ty Johnduhart
Comment:
<pre>+ foreach ( $wgAddThisHServ as $n => $a ) {
+ $output .= '<a
class="addthis_button_'.$wgAddThisHServ[$n]["service"].'"
'.$wgAddThisHServ[$n]["attribs"].'></a>';
+ }</pre>
This will cause PHP notices since attribs won't always be set, check with
isset().
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
