User "Hashar" changed the status of MediaWiki.r102683. Old Status: new New Status: fixme
User "Hashar" also posted a comment on MediaWiki.r102683. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102683#c26623 Commit summary: Add $fname to tableExists Pass $fname/__METHOD__ in in upstream callers Comment: Looks like it will break MSSQL / Postgre tableExists() calls since you are changing the parameter order: - function tableExists( $table, $schema = false ) { + function tableExists( $table, $fname = __METHOD__, $schema = false ) { Also, instead of passing the calling method as an argument, can't we look up the calling function from the stack table? This way we could get ride of those $fname = __METHOD__ arguments. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
