User "Catrope" posted a comment on MediaWiki.r103726. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103726#c26669 Commit summary:
The rest of r103724 ...( r103724 was committed broken because of cancel accidental "enter" then subsequent cancel :( ) ~my bad~ Full description of: r103724: == More consistency tweaks == * camel case * brackets around short conditionals == Sync with Kaltura trunk ( mw.EmbedPlayer.js ) == * adds TimeDisplayWidth and ControlsHeight configuration Event name sync: ( for plugin compatibility ) * use the "newEmbedPlayerEvent" event instead of EmbedPlayerNewPlayer * use "checkPlayerSourcesEvent" instead of "CheckPlayerSources" mw.EmbedPlayer.js: * adds methods: useNativePlayerControls, * adds bindHelper methods for close context errors in iOS for plugins * spaces fixes for mw.EmbedPlayer to match kaltura version * add loading spinner support * generalized disable seekBar to enable/disable PlayControls * includes error message handler * improved end timeline events * separated play event and interface updates * cleaner function name for iframe share code * static helper for getting a compatible source from source set ( getCompatibleSource ) ~ and other small changes and synchronization ~ Comment: You'll have to quote code in a pre tag, or the HTML in it will be interpreted by MediaWiki. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
