User "Reedy" changed the status of MediaWiki.r82273. Old Status: resolved New Status: fixme
User "Reedy" also posted a comment on MediaWiki.r82273. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82273#c26675 Commit summary: Moved Skin::makeGlobalVariablesScript() to OutputPage::getJSVars() * merged <script> and if ( window.mediaWiki ) block with the one of mediaWiki.loader as stated in the doc * removed dependency of $wgTitle * the two only calls to this functions are in SemanticForms, but will not affect current version of MediaWiki: ** specials/SF_UploadWindow.php: this file is only used before 1.16 ** specials/SF_UploadWindow2.php: the call is part of the else branch of a "method_exists( $wgOut, 'addModules' )" check, which means it's not called since 1.17 Comment: See bug 32702 Breaking interfaces like this is not cool The function (Skin::makeGlobalVariablesScript) wasn't deprecated in an shape or form, and then it just disappeared between 1.17 and 1.18? :/ Even if it wasn't supposed to be public, it is/was, and was being used in other skins _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
