"Nikerabbit" changed the status of MediaWiki.r104473 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104473#c26740
Old Status: new > New Status: ok Commit summary for MediaWiki.r104473: * (bug 32659) Code cleanup: normalize order of params to implode() in Language:: functions Patch by Daniel Werner, https://bugzilla.wikimedia.org/attachment.cgi?id=9555&action=diff For "historical reasons" implode() accepts parameters as ($list, $sep) as well as the usual ($sep, $list) but it's better to use the standard to be clear. Nikerabbit's comment: Those type annotations might catch some bugs later on. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
