"Hashar" posted a comment on MediaWiki.r104563. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104563#c26778
Commit summary for MediaWiki.r104563: Fix fatal error when running newParserTest The delayed parser test feature was expecting a ParserTest object which is almost never the case when using the NewParserTest for PHPUnit. The class name is forged after the file name! They at least all extends NewParserTest no polymorphism? no multiple hinting. Be creative the PHP way by writing your own code :-( Hashar's comment: I was ranting about PHP not supporting multiple types/class hinting nor polymorphism. Forging the class name using the .txt filename is fine :p I will eventually one day merge the ParserTest and NewParserTest class. Not sure why we had to duplicate them. NewParserTests was probably written as a replacement for ParserTests. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
