"Reedy" posted a comment on MediaWiki.r103706. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103706#c26806
Commit summary for MediaWiki.r103706: * (bug 8859) Database::update should take array of tables too Original patch by Andrew Dunbar Also apply in DatabaseOracle and DB2 code as they override update Reedy's comment: http://dev.mysql.com/doc/refman/5.0/en/update.html Multiple-table syntax: <pre> UPDATE [LOW_PRIORITY] [IGNORE] table_references SET col_name1={expr1|DEFAULT} [, col_name2={expr2|DEFAULT}] ... [WHERE where_condition] </pre> For MySQL at least, there is no join conditions on an update... You'd have to do it $cods... Having said that... http://www.sqlite.org/lang_update.html SQLite doesn't do multiple table updates http://www.postgresql.org/docs/8.2/static/sql-update.html Same for Postgres http://psoug.org/reference/update.html And seemingly for Oracle Seems to make more sense to just revert this commit, and close the bug as essentially invalid? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
