"Nikerabbit" changed the status of MediaWiki.r104518 to "fixme" and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104518#c26814
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r104518:
remove unnecessary dom parsing
Nikerabbit's comment:
<pre>
+ if ( self::$title == 'Special:UserLogin' ) {
</pre>
This just looks wrong.
Don't use empty if the variable is always set. getLocalUrl accepts also an
array of parameters and does the escaping for you in that case.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
