"Johnduhart" changed the status of MediaWiki.r104504 to "fixme" and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104504#c26852
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r104504:
Added one pathway for edit tracking: add info to query string and pass through
as hidden variables on the edit page:
- articleFeedbackv5 jquery plugin:
- New property feedbackId
- Updated ctas[1].build() to add the feedback id, cta id, and
bucket id
to the query string for edits
- Updated submitForm() to grab the feedback and cta ids from the
returned data on success
- Fixed showCTA(); no longer needs to accept a cta id
- Updated ApiArticleFeedbackv5 to return the feedback and cta ids
- ArticleFeedbackv5Hooks:
- New methods pushTrackingFieldsToEdit() and trackEdit()
* NB: only prints info to the log; method of storage is still
not in
the spec.
- ArticleFeedbackv5.php:
- Added ArticleFeedbackv5Hooks::pushTrackingFieldsToEdit() to
the
"EditPage::showEditForm:fields" hook
- Added ArticleFeedbackv5Hooks::trackEdit() to the
"ArticleSaveComplete" hook
Removed old pitch handling from ext.articleFeedbackv5.js (can use version 4 as a
reference; no need to keep it around)
Johnduhart's comment:
<pre>+ msg = 'Unknown error';
</pre>
Shouldn't this be localized?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
