"Jack Phoenix" posted a comment on MediaWiki.r104990.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104990#c26887

Commit summary for MediaWiki.r104990:

description message name corrected and minor formatting.

Jack Phoenix's comment:

<pre><nowiki>
-                               } else {
+                                       }
+                               }
+                               else {
</nowiki></pre>
Uh? <code>} else {</code> is the recommended version (and also the one which 
makes sense, IMHO, as such a simple expression should not take more than one 
line; most certainly not three lines, like I've sometimes seen some people at 
other projects do) as per our [[Manual:Coding conventions|coding conventions]].

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to