"SPQRobin" posted a comment on MediaWiki.r104483.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104483#c26907

Commit summary for MediaWiki.r104483:

* (bug 27721) Make JavaScript variables wgSeparatorTransformTable and 
wgDigitTransformTable depend on page content language so the sort script sorts 
correctly more often. It will e.g. sort according to the user language on 
special pages, where localised numbers are usually used.
* New JavaScript variable wgPageContentLanguage (independent from the bug, but 
I assume this var can be useful)

SPQRobin's comment:

I don't yet know how to write tests, but most importantly I don't know in which 
way I could/should test this. Will try to figure that out.

I can give you examples to see how this works: sorting e.g. 
https://translatewiki.net/wiki/Special:ContributionScores?uselang=fa (where 
page content language [fa] matches language of numbers [fa]) works, versus 
sorting e.g. 
https://translatewiki.net/wiki/User:SPQRobin/sandbox?uselang=fa#Special:ContributionScores
 (where page content language [en] doesn't match language of numbers [fa]) 
doesn't work. Previously both didn't work.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to