"TheDJ" posted a comment on MediaWiki.r105120.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105120#c26920

Commit summary for MediaWiki.r105120:

* (bug 32095) High-density Android, iPhone versions of search icon

Other icons not added. May not work in all browsers.
There's definitely a lot of CSS duplication -- nearly the same bits for 
android, iphone, default, webkit..... they should all get the same stylesheet. 
Why have multiples?

Using -webkit-pixel-density media query; this means it doesn't trigger on 
Firefox of course. Firefox should take -moz-pixel-density but seems happier 
with checking the dpi. Not applied.

TheDJ's comment:

The reason there are multiple stylesheets is historical. The old ruby gateway 
used ruby code to generate device specific stylesheets from base components. 
When the layout was copied into MobileFrontend, The 'generated' per device 
stylesheets, instead of the components were imported, simply to get towards a 
working yet compatible extension as fast as possible. There is no good reason 
to continue to use multiple stylesheets, if we can take out the device specific 
bits.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to