"MaxSem" posted a comment on MediaWiki.r95023.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95023#c26944

Commit summary for MediaWiki.r95023:

Don't check for each database's availability twice. This halves the number of 
ugly message boxes seen during CLI installation on Windows if Oracle is not 
installed, but its bindings for PHP are.

MaxSem's comment:

Namely, the list od databases appeared to change for him some time during 
installation. I tried reverting this revision and it seemed to help. Because it 
was just a couple of minutes before the hackathon ended, we had no time for 
further investigations. I guess this revision can be re-ok'd since there were 
no reports that it causes any problems with existing databases. Instead, we 
could revisit this when DJ's MSSQL branch will be ready.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to