"Hashar" changed the status of MediaWiki.r96753 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96753

Old status:  new
> New status: ok

Commit summary for MediaWiki.r96753:

mediawiki.log.js: Add support for variadic arguments (just like the native 
console does)
* Use unshift() when calling window.console.log (that way logging an object 
will not result in "prefix> [object Object]" but in "prefix> { key: .., .. }" 
(which most consoles do, similar thing for logging elements for which most 
console API implementations offer special features)
* Use string concatenation when using our own fabricated log. Did not use 
unshift for both, because in the latter that would show a bad comma ("prefix:>, 
foo, bar"). The native API does not show a comma between two logged variables, 
they're just shown next to each other.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to