"Kaldari" posted a comment on MediaWiki.r105239. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105239#c26993
Commit summary for MediaWiki.r105239: [HarvardResearch][CentralNotice] Temporary wgNoticeBanner_Harvard2011 data. -- Banner display is handled through JavaScript because it's CentralNotice that is also for anonymous users and page output must be unaffected. -- Banner submission to Harvard/Science PO needs a hash of which the salt must not be in cleartext in the front-end code (also generating hashes in JS is ugly). So we need at least one temporary server component. -- Instead of requesting things from 2 or three different APIs on all pages + outputting a hash from PHP, might as well do it all in PHP and output an object in mw.config with all the needed data -- Cached in the session. Not sure whether it should be in memcached or session. Choose session for now since this is going to happen for all logged-in users on en.wiki, not sure wether it's good to have a gazillion memcached entries only used by 1 user only needed for about a week. -- Also notices that session is somewhat tied into memcached Kaldari's comment: Looks good. My only suggestion is that you probably don't need to refetch the username since it's already available in wgUserName. Marking inspected. I'll let someone else sanity check for DB load before marking OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
