"Awjrichards" changed the status of MediaWiki.r104648 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104648#c26999

Old Status: new
> New Status: ok

Commit summary for MediaWiki.r104648:

followup r104503, r104539, r104588
Limbo queue consumer IN the orphan rectifier: Initial commit for all the 
command-line stuff. This has yet to be thoroughly tested and as such, should 
not be used by anyone.

Awjrichards's comment:

<pre>
+               $data = array(
+                       'wheeee' => 'yes'                       
+               );
+               $this->adapter = new 
GlobalCollectOrphanAdapter(array('external_data' => $data));
</pre>
Please comment around this whatever is going on here :p

<pre>
+       function getStompOrphans(){
+               $time_buffer = 60*20; //20 minutes? Sure. Why not? 
+               $selector = "payment_method = 'cc'";
+               $messages = stompFetchMessages( 'limbo', $selector, 300 );
</pre>
It would be great if the batch size for stompFetchMessages was configurable, as 
well as the $time_buffer.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to