"Brion VIBBER" changed the status of MediaWiki.r92081 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92081#c27046
Old Status: ok > New Status: fixme Commit summary for MediaWiki.r92081: Added us_status column for future expansion re Bryan's suggestion Implemented changes suggested in code review on r92009: constructor bug handling passed repo/stash up-to-date timestamp generation fetching db handle from repo iterating over select results according to convention changed uploadstash.us_media_type to enum to mirror image.img_media_type removed (most) new references to $wgUser, instead using ApiBase::createContext to find the user Brion VIBBER's comment: This line: 'us_timestamp < ' . $dbr->timestamp( time() - UploadStash::REPO_AGE * 3600 ), fails for DBs where native timestamps contain formatting chars and spaces, such as PostgreSQL (bug 32822). You need to quote the resulting string. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
