"MarkAHershberger" posted a comment on MediaWiki.r98339.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98339#c27085
Commit summary for MediaWiki.r98339:
* (bug 31204) Remove old user.user_options
Added run of ConvertUserOptions maintenance script into update.php before
dropping the column
Removed usages of user_options in code
Marked User::decodeOptions() deprecated as of 1.19.
Made ConvertUserOptions drop out early if the user_options field doesn't exist
Made ConvertUserOptions update user_options to '' after migration of user
options to mOptions
MarkAHershberger's comment:
- $this->decodeOptions( $row->user_options );
- $this->mTouched = wfTimestamp(TS_MW,$row->user_touched);
+ if ( isset( $row->user_options ) ) {
+ $this->decodeOptions( $row->user_options );
+ }
+ $this->mTouched = wfTimestamp( TS_MW,
$row->user_touched );
At least the above snippet, probably the whole diff, needs to be backported to
the 1.18 tarball branch since otherwise the errors about user_options not being
a member of stdClass will be generated in some cases.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
