"Awjrichards" posted a comment on MediaWiki.r105145.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105145#c27086

Commit summary for MediaWiki.r105145:

rewriting FundraisingStatistics to use 1 query instead of 6, and heavily cache 
results from previous years

Awjrichards's comment:

<pre>
+                       if ( $mostRecent ) {
+                               $wgMemc->set( $key, $result, 
$egFundraiserStatisticsCacheTimeout );
+                       } else {
+                               #$wgMemc->set( $key, $result, 86400 );
+                       }
</pre>

It would be great to have both cache timeouts be configurable. I don't see why 
we can't potentially cache other results for even longer than 24 hours.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to