"Tim Starling" changed the status of MediaWiki.r102504 to "reverted"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102504

Old status:  new
> New status: reverted

Commit summary for MediaWiki.r102504:

Allow \x1b (ascii ESC) in wfDebug() output

It is a local hack I had to let me pass colored debug message using a local
wrapper:

function wfDebugGreen($msg) {
        $color = "\x1b[1;32m"; # Green
        $reset = "\x1b[1;0m";
        wfDebug( $color . $msg . $reset );
}

Ideally \x1b should only be kept if it is followed by /(\d+(;\d)?)?+m/
which should match the 'graphic rendering' ANSI escape code.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to