"Jeroen De Dauw" posted a comment on MediaWiki.r105475. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105475#c27244
Commit summary for MediaWiki.r105475: move incorrectly place adding of licenses to fix bug 32860 Jeroen De Dauw's comment: I don't think this rev changed anything other then the message stuff. > you iterate over $globalConfig['licenses'] but then add the values to > 'licensesOwnWork' Yeah, what's wrong with this? The licensesOwnWork thing is a list of options for the license selection thing, not the list of own work licenses that should be shown in the UW UI itself. It might be better if the license definitions distinguished between which ones belong the the own work category and which ones belong to the third party one, so the code here could omit these that are not relevant. My original code actually just added the own work licenses enabled by default in the config file, but you changed this, as we need the other licences to be available as options as well. > all the licenses are there for own-work, none for third party? Ther above comment explains why all licences are under the own work options. There is no third party option, since this was never needed for WLM. I could add one if that is useful. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
