"Liangent" posted a comment on MediaWiki.r104041. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104041#c27274
Commit summary for MediaWiki.r104041: Followup r103763: per Liangent's CR comment, there was a bug where an unchanged message would cause the fallback language to be accessed instead. Per my CR comment, this can be solved by explicitly storing unchanged messages (but not storing messages whose English translations have changed). I've also revised the logic for carrying over stored messages from the cache file: previously messages would never be removed from the cache file, which would cause issues when people deliberately remove messages to let the fallback kick in. The logic has now been changed to remove messages from the LU cache if they've been removed from trunk, but to keep them (at their cached version) if they still exist in trunk but their English translation has changed. Liangent's comment: There is another way to go: iterate over all keys in English where English text is not changed when updating (= building cache), then calculate (resolve fallback now) its message text in every language and store it in cache. When recaching the message, simply merging cached data into main data is fine. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
