"Johnduhart" posted a comment on MediaWiki.r105810.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105810#c27292

Commit summary for MediaWiki.r105810:

Removed usages of empty()

/me tends to wounds on foot

Johnduhart's comment:

<pre>-
-       private static function checkArticle( $article, $category_filters ) {
-               // Check category
-               if( count( $category_filters ) == 0 || ( 
count($category_filters) == 1 && empty( $category_filters[0] ) ) ) {
-                       return true;
-               }
-
-               foreach( $category_filters as $category ) {
-                       if( in_array( $category, $article['categories'] ) ) {
-                               return true;
-                       }
-               }
-               return false;
-       }</pre>

Whoah why'd this go? That wasn't in the commit summary.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to