"Schnark" posted a comment on MediaWiki.r105664.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105664#c27321
Commit summary for MediaWiki.r105664:
* Revert r103476, r105161 and implement the fix for bug 32858 (a.k.a. bug
32450) in WikiPage instead. See comment 14 for further rationale.
* Clarified release notes. Please write what the new code does, not the bug
description.
Schnark's comment:
As an author of quite some user scripts I really dislike this change. It is
very important for me to find out who is using my scripts by looking at the
backlinks. It allows me to decide if backwards compatibility is needed, to find
bugs the users don't report to me (I had never found out that in some cases one
of my scripts edited [[User_talk:Undefined]] otherwise), etc.
Responsible users know that they must put their scripts in nowiki-tags, at
least the
[//de.wikipedia.org/wiki/Wikipedia:Technik/Skin/JS#.3Cnowiki.3E_in_Skripten
German documentation] mentions this fact.
Okay, some scripts pollute the tables, because some users forgot to wrap their
scripts with nowiki-tags, but what's the problem with that? I can pollute the
tables by random stuff on my user page, the tables are polluted by users
forgetting the colon before interwikilinks:
[//en.wikipedia.org/w/api.php?action=query&generator=allpages&gapfilterlanglinks=withlanglinks&gapnamespace=4&gapprefix=Reference_desk/&proo=langlinks].
So this change won't stop unwanted links from showing up in the tables.
As long as there isn't a good alternative to find out who is using one's
scripts, this feature shouldn't be disabled. At least the text inside
javascript comments should still be parsed as it was also mentioned in the bug.
This change has another serious problem: It breaks [[Extension:SpamBlacklist]].
Steps to reproduce:
# Create [[User:NAME/spam]] with <nowiki>{{User:NAME/spam.js}}</nowiki>
# Create [[User:NAME/spam.js]] with [''some blocked URL'']
# Purge [[User:NAME/spam]]
Before this change the edit in step 2 was denied, after this change the edit is
allowed, the link shows up on the user page. (Note: You can't swap step 1 and
2, this will still trigger SBL.)
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
