"Hashar" posted a comment on MediaWiki.r105812. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105812#c27332
Commit summary for MediaWiki.r105812: Introduce a Language::getHtmlLang method which returns the Bcp47 formatted language code and update code around core to output lang tags using this method instead of getCode so that we properly output things like lang="en-CA" instead of lang="en-ca" Hashar's comment: wfBcp47 is named with some more upper cased characters: wfBCP47. Running wfBCP47 should only be done when changing the language code, not on each call. <tt>en-CA</tt> and <tt>en-ca</tt> are both fully valid. BCP 47 does not enforce any case sensitivity so it is really useless to do that kind of formatting. Anyway, the most important point is: why do you introduce getHtmlCode() when ->mCode is already a valid BCP47 language code? :-) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
