"^demon" posted a comment on MediaWiki.r105853.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105853#c27342

Commit summary for MediaWiki.r105853:

* (bug 32958) SpecialAllMessages: input form doesn't show and remember filter 
option

Did this a little differently, but inspired by MrBlueSky's patch: 
https://bugzilla.wikimedia.org/attachment.cgi?id=9655

Rather than using the $this->custom values to check as in the patch, I moved 
$this->filter from the specialpage class (where it wasn't being used) to the 
pager class (where it was being used). Probably left over from a refactor.

^demon's comment:

Could you reuse $this->filter below on $this->custom?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to