"SPQRobin" posted a comment on MediaWiki.r105870.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105870#c27360

Commit summary for MediaWiki.r105870:

Followup to r105854. Made directionality inline rather than block-level, 
because text alignment should be consistent with the rest of the site. Added 
support for Monobook and Modern skins.

SPQRobin's comment:

When dir="auto" is on the h1 element, the whole title is at either the left or 
the right. Having a span tag leaves the title at the side of the user language 
direction, but makes neutral-direction characters (like exclamation marks) 
still display correctly.

So I think this commit is good, although the remaining skins need dir="auto" as 
well.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to