"Catrope" changed the status of MediaWiki.r105252 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105252#c27362
Old Status: deferred
> New Status: fixme
Commit summary for MediaWiki.r105252:
Tweaks and bug fixes for API uils class, as per Roan's review:
- Fixed incorrect global of $wgArticleFeedbackNamespaces
- Removed getRevisionId(), removed pointless use in view ratings api
call
(rev id is never used), and replaced use in submit api call with
$title->getLatestRevID()
- Fixed doc block for getFields()
- Removed if statement to create an array before appending in
getOptions()
Catrope's comment:
<pre>
- $revId = ApiArticleFeedbackv5Utils::getRevisionId(
$params['pageid'] );
+ $title = Title::newFromID( $params['pageid'] );
+ $revId = $title->getLatestRevID();
</pre>
This will cause a fatal error if the given page ID is invalid, because
newFromID() returns null in that case. Should be easy to reproduce by passing
pageid=0.
OK otherwise, marking fixme because of the fatal.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
