"Catrope" changed the status of MediaWiki.r105448 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105448#c27381
Old Status: deferred > New Status: fixme Commit summary for MediaWiki.r105448: Making long-delayed schema updates to AFTv5, per Roan's feedback in the CodeReview. Catrope's comment: <pre> - 'af_user_text' => $wgUser->getName(), + 'af_user_ip' => $ip, </pre> This means you're putting the user's IP address in the table unconditionally, '''even if the user is logged in'''. Please don't do this. We're not completely against tracking this information, but the IP address of logged-in users is considered private information that we don't share with the outside world. By storing it in the af_ table you're 'tainting' it so it can't be made available to the public without being censored. I suggest you just don't store this information (and set user_ip to NULL if user_id != 0) so as to make publishing the data easier. OK otherwise. Marking fixme for the privacy issue. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
